Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup promises #243

Merged
merged 1 commit into from
Jun 26, 2018
Merged

cleanup promises #243

merged 1 commit into from
Jun 26, 2018

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Jun 26, 2018

given that this.makeRequest is already wrapped in RSVP/Ember Promise there is no need wrap it again with RSVP Promise

@@ -244,7 +239,7 @@ export default TokenAuthenticator.extend({
delete this._refreshTokenTimeout;
cancel(this._tokenExpirationTimeout);
delete this._tokenExpirationTimeout;
return new resolve();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need new, it already returns new instance of Promise

@bekzod bekzod force-pushed the cleanup-promise branch from 9cc3f1f to 5102353 Compare June 26, 2018 12:47
@fenichelar fenichelar merged commit 607d6bf into fenichelar:master Jun 26, 2018
@fenichelar
Copy link
Owner

Awesome! :)

@bekzod bekzod deleted the cleanup-promise branch June 26, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants