Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ember-get-config to production dependencies #229

Merged
merged 2 commits into from
Jun 5, 2018
Merged

move ember-get-config to production dependencies #229

merged 2 commits into from
Jun 5, 2018

Conversation

jakesjews
Copy link
Contributor

Without this package in production dependencies I am getting errors about importing ember-get-config.

fenichelar
fenichelar previously approved these changes Jun 5, 2018
View reviewed changes
@fenichelar
Copy link
Owner

@jakesjews Great! In the interest of time, would you mind incrementing the version in package.json and package-lock.json to 4.0.1?

@jakesjews
Copy link
Contributor Author

sure thing

fenichelar
fenichelar approved these changes Jun 5, 2018
View reviewed changes
Copy link
Owner

@fenichelar fenichelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fenichelar
Copy link
Owner

@jpadilla I think we will want to get a new release pushed out to NPM asap - v4.0.1.

@jpadilla jpadilla merged commit 4337e66 into fenichelar:master Jun 5, 2018
@jpadilla
Copy link
Contributor

jpadilla commented Jun 5, 2018

Just released v4.0.1! Thank you @jakesjews and @fenichelar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenichelar fenichelar fenichelar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakesjews @fenichelar @jpadilla