Removed insecure credentials transmission warning

fenichelar · Jan 18, 2015 · b9537a2 · b9537a2 · dennismende · Jan 27, 2015
1 parent f2ae79e
commit b9537a2
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 44 deletions.
diff --git a/addon/authenticators/token.js b/addon/authenticators/token.js
@@ -1,6 +1,5 @@
 import Ember from 'ember';
 import Base from 'simple-auth/authenticators/base';
-import isSecureUrl from '../utils/is-secure-url';
 import Configuration from '../configuration';
 
 /**
@@ -153,9 +152,6 @@ export default Base.extend({
     @private
   */
   makeRequest: function(data) {
-    if (!isSecureUrl(this.serverTokenEndpoint)) {
-      Ember.Logger.warn('Credentials are transmitted via an insecure connection - use HTTPS to keep them secure.');
-    }
     return Ember.$.ajax({
       url: this.serverTokenEndpoint,
       type: 'POST',

diff --git a/addon/authorizers/token.js b/addon/authorizers/token.js
@@ -1,6 +1,5 @@
 import Ember from 'ember';
 import Base from 'simple-auth/authorizers/base';
-import isSecureUrl from '../utils/is-secure-url';
 import Configuration from '../configuration';
 
 /**
@@ -75,16 +74,11 @@ export default Base.extend({
 
     @method authorize
     @param {jqXHR} jqXHR The XHR request to authorize (see http://api.jquery.com/jQuery.ajax/#jqXHR)
-    @param {Object} requestOptions The options as provided to the `$.ajax` method (see http://api.jquery.com/jQuery.ajaxPrefilter/)
   */
-  authorize: function(jqXHR, requestOptions) {
+  authorize: function(jqXHR) {
     var token = this.buildToken();
 
     if (this.get('session.isAuthenticated') && !Ember.isEmpty(token)) {
-      if (!isSecureUrl(requestOptions.url)) {
-        Ember.Logger.warn('Credentials are transmitted via an insecure connection - use HTTPS to keep them secure.');
-      }
-
       if(this.authorizationPrefix) {
         token = this.authorizationPrefix + token;
       }

diff --git a/addon/utils/is-secure-url.js b/addon/utils/is-secure-url.js
diff --git a/tests/unit/utils/is-secure-url-test.js b/tests/unit/utils/is-secure-url-test.js