Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added useful editions to animation plotting #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added useful editions to animation plotting #8

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e522958
Added useful editions to animation plotting
rgerru Sep 11, 2023
ae52707
Added a comma and changed if condition for animation limits
rgerru Sep 11, 2023
5659614
Changed the if condition for xlim and ylim
Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions xfeltor/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def animate_pcolormesh(
axis_coords=None,
vmin=None,
vmax=None,
xmin=None,
xmax=None,
ymin=None,
ymax=None,
vsymmetric=False,
logscale=False,
fps=10,
Expand All @@ -102,6 +106,8 @@ def animate_pcolormesh(
aspect="auto",
extend=None,
controls="both",
LCFS=None,
cmap='bwr',
**kwargs,
):
"""
Expand Down Expand Up @@ -137,6 +143,8 @@ def animate_pcolormesh(
vmax : float, optional
Maximum value to use for colorbar. Default is to use maximum value of
data across whole timeseries.
xmin, xmax, ymin, ymax : float, optional
Range for plotting the animation. Default is to use the whole data range.
vsymmetric : bool, optional
If set to true, make the color-scale symmetric
logscale : bool or float, optional
Expand Down Expand Up @@ -165,6 +173,12 @@ def animate_pcolormesh(
By default, add both the timeline and play/pause toggle to the animation. If
"timeline" is passed add only the timeline, if "toggle" is passed add only the
play/pause toggle. If None or an empty string is passed, add neither.
LCFS : float, optional
To plot on the animation the LCFS. If set LCFS=data["Rho_p"][0], it plots the LCFS.
Not easy to define it as rho=1. Future improvement, but not easy with animation.
Styling and more lines can be defined in line 292.
cmap : string, optional
Allows to define the cmap of the animation. Default set to 'bwr'.
kwargs : dict, optional
Additional keyword arguments are passed on to the animation function
animatplot.blocks.Pcolormesh
Expand Down Expand Up @@ -249,7 +263,7 @@ def animate_pcolormesh(
UserWarning,
)
pcolormesh_block = amp.blocks.Pcolormesh(
x_values, y_values, image_data, shading="auto", ax=ax, **kwargs
x_values, y_values, image_data, shading="auto", ax=ax, **kwargs, cmap=cmap,
)

if animate:
Expand All @@ -267,16 +281,22 @@ def animate_pcolormesh(

# Add title and axis labels
ax.set_title(variable)
if None not in (xmin, xmax):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pass None to ax.set_xlim:

ax.set_xlim(None, 10)

Passing None leaves the limit unchanged. You could remove the if None not in (min, max) then.

ax.set_xlim(xmin, xmax)
if None not in (ymin, ymax):
ax.set_ylim(ymin, ymax)
ax.set_xlabel(x_label)
ax.set_ylabel(y_label)

if LCFS is not None:
plt.contour(LCFS.x, LCFS.y, LCFS, levels=0, colors='black', linestyles='dashed') #Edit styling LCFS
if animate:
_add_controls(anim, controls, t_label)

if save_as is not None:
if save_as is True:
save_as = f"{variable}_over_{animate_over}"
anim.save(save_as + ".gif", writer=PillowWriter(fps=fps))
anim.save(save_as + ".gif", writer=PillowWriter(fps=fps), dpi=500)
return anim
return pcolormesh_block

Expand Down