Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the base16 aspect vs bytes aspect of WKB #166

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Clarify the base16 aspect vs bytes aspect of WKB #166

merged 1 commit into from
Dec 15, 2021

Conversation

josevalim
Copy link
Contributor

No description provided.

@josevalim
Copy link
Contributor Author

josevalim commented Nov 20, 2021

Hi @bryanjos! Thanks for the great project! :)

I was a bit confused that WKB did not return a binary and we were base16 encoding it by default. One option is to deprecate encode! and some of the branches in decode, but assuming it is probably too late for that, I submitted a PR that changes the docs to better clarify where and how it handles both formats.

@wojtekmach
Copy link
Contributor

wojtekmach commented Nov 20, 2021

Should we deprecate WKB.encode, WKB.decode("00" <> ...), and WKB.decode("01" <> ...) with a message pointing towards functions that work on bytes? Happy to send a PR.

@bryanjos
Copy link
Contributor

Hey @josevalim thanks for the PR! I'm definitely open to deprecating what needs to be in order to make things better and less confusing. Same thing with what @wojtekmach mentioned. Sorry it took me so long to get to this. But I'm happy to accept PRs for anything that can help in that effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants