Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode 🌙 #835

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Dark mode 🌙 #835

merged 3 commits into from
Oct 13, 2024

Conversation

difagume
Copy link
Contributor

#471
Dark mode is added using next-themes, a switch is added in the configuration to be able to change between light and dark, the default mode is the system mode.

1
2
3
4

@felixmosh
Copy link
Owner

Wow, man, this looks great!
Thank you for this PR.
I'm not sure why do we need next-theme?
With your permission, I would like to change some colors, is that OK by U?

@difagume
Copy link
Contributor Author

Hi @felixmosh, now that you mention it, you're right about whether next-themes is necessary 🤔. I started by installing next-themes and creating color variables for each style module until I stopped seeing colors that clashed with dark mode. Perhaps without realizing it, I changed all the colors and next-themes might no longer be necessary.

Please feel free to make any adjustments. If you think it can help to have dark mode, I'm very happy to have been able to contribute something. 😊

@felixmosh felixmosh merged commit 278559f into felixmosh:master Oct 13, 2024
4 checks passed
@difagume difagume deleted the dark-mode branch October 13, 2024 18:09
@felixmosh
Copy link
Owner

It got released in v6.2.0
There is more room for improvments, but it is Good enough, thanks.
I will modify some things with a time...

@felixmosh
Copy link
Owner

felixmosh commented Oct 14, 2024

Progress
image
image
image

:]

@difagume
Copy link
Contributor Author

I was reviewing it, and with the latest adjustments, it looks very good and sharper 👏

@felixmosh
Copy link
Owner

Fixed all dark mode issues in latest version.
Thank you for pushing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants