Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fastify dependencies to support Fastify v5 #824

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

mduchev
Copy link
Contributor

@mduchev mduchev commented Sep 25, 2024

Last week Fastify v5 was released - https://github.com/fastify/fastify/releases

This PR addresses this issue #823 and updates the relevant dependencies in order to support Fastify v5.

@fastify/static got support for v5 in version 8.0.1 and @fastify/view got support for it in version 10.0.1

@felixmosh
Copy link
Owner

There are any other breaking changes?

@mduchev
Copy link
Contributor Author

mduchev commented Sep 25, 2024

@felixmosh I'm not sure how to properly test it after the package updates, but taking a look at the release notes for all 3 dependencies, I don't see anything breaking at all. Here's the list of changes:

https://github.com/fastify/fastify-static/releases
https://github.com/fastify/point-of-view/releases
https://github.com/fastify/fastify/releases

@arthurfiorette
Copy link

@felixmosh its safe to merge, both of the dependent packages didn't received any breaking change for support for fastify v5.

@arthurfiorette
Copy link

Fastify v5 requires node 20+, this CI configuration is using node 18.

@arthurfiorette
Copy link

arthurfiorette commented Sep 27, 2024

Node 20 will enter maintaince mode in 2024-10-22, so its safe to repeat this commit, but for 20.x, 22.x.

For those coming here and can't wait for the update, using pnpm/yarn resolutions you can solve this:

"resolutions": {
  "@fastify/static": "^8.0.1",
  "@fastify/view": "^10.0.1"
},

@andresribeiro
Copy link

andresribeiro commented Sep 28, 2024

"@fastify/static": "^8.0.1",
  "@fastify/view": "^10.0.1"

for those using bun as package manager:

"overrides": {
	"@fastify/static": "^8.0.1",
	"@fastify/view": "^10.0.1"
},

@felixmosh felixmosh merged commit ef1784c into felixmosh:master Sep 29, 2024
2 of 4 checks passed
@felixmosh
Copy link
Owner

Thank you for your contribution 🙏🏽

@felixmosh
Copy link
Owner

Released in V6.0.0

@mduchev mduchev deleted the chore/update-fastify-deps branch October 4, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants