Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elysia adapter #769

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Add elysia adapter #769

merged 9 commits into from
Nov 12, 2024

Conversation

kravetsone
Copy link
Contributor

@kravetsone kravetsone commented Jun 8, 2024 •
edited
Loading

Elysia is a great framework for Bun

@felixmosh
Copy link
Owner

Hi @kravetsone Thank you for your contribution, is this PR ready for review?

@kravetsone kravetsone marked this pull request as ready for review June 15, 2024 14:29
@kravetsone
Copy link
Contributor Author

Hi @kravetsone Thank you for your contribution, is this PR ready for review?

For now, yes! I test it and it work for me. I also improve example, package.json and README

@felixmosh
Copy link
Owner

Hi, thanks,

I'll review it ASAP

@kravetsone
Copy link
Contributor Author

Some actions failed
Maybe we need add skipLibCheck option?

@felixmosh
Copy link
Owner

Yeap, we mist address this...

@niklas-stegmann
Copy link

Hey,
are there any updates on this PR? I would love to use it in my project!

@kravetsone
Copy link
Contributor Author

What i can do?

@felixmosh
Copy link
Owner

felixmosh commented Oct 7, 2024 •
edited
Loading

Can you fix the types errors?

@brenodanyel
Copy link

Updates? Please finish it when you have time.

@kravetsone
Copy link
Contributor Author

yarn is sooo slow

@kravetsone
Copy link
Contributor Author

can i switch from tsc in my package?

I want to ship ESM & cjs together

@kravetsone
Copy link
Contributor Author

@felixmosh i guess it ready for review/rerun CI

@kravetsone
Copy link
Contributor Author

sorry for sooo late response

@felixmosh
Copy link
Owner

felixmosh commented Nov 9, 2024 •
edited
Loading

I'm AFK, I'll review it ASAP, thank you

@kravetsone
Copy link
Contributor Author

I'm AFK, I'll review it ASAP, thank you

don't worry! I pinged you just so you'd notice) I sometimes got lost in notifications myself

felixmosh
felixmosh reviewed Nov 12, 2024
View reviewed changes
Copy link
Owner

@felixmosh felixmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kravetsone the adapter looks OK, can you check me comment?

packages/api/tsconfig.json Show resolved Hide resolved
@felixmosh felixmosh merged commit f07c544 into felixmosh:master Nov 12, 2024
4 checks passed
@kravetsone kravetsone mentioned this pull request Nov 12, 2024
Closed
felixmosh added a commit that referenced this pull request Nov 13, 2024
@felixmosh
Revert "Add elysia adapter (#769)"
4b175fa 
This reverts commit f07c544
@kravetsone kravetsone mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmosh felixmosh felixmosh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kravetsone @felixmosh @niklas-stegmann @brenodanyel