-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide bull routes from schema/openAPI generation #762
Conversation
This hides the bullboard routes from openAPI schema generation. These routes don't have a schema defined, so they aren't useful in that context.
Hi @bcomnes do you think that it is a good idea to add schema or just hide them? |
I think it's better to just hide them. It seems unlikely any fastify server exposing a published openAPI spec based on its schema would also want to include unreleated bull-board routes in that spec. It seems much more likely of a scenario that someone has created an API with fastify, and wants to add bullboard as a backend management tool and not expose that detail to their public API docs via openAPI. If there does happen to be someone out there who does want it exposed, perhaps we could leave that option/schema as an open contribution task for them. Either way, it should default to being hidden. |
Thanks for the quick turnaround! Enjoying bullboard so far. |
Its supplemented in when you add the first party openapi plugin. Otherwise its ignored. You could safely ts-ignore this, or perhaps accept a schema option in registerPlugin(). That would match the supplemented FastifySchema during development for users. Preferences? |
Just ignore it, if someone will need the abillity to pass a schema, he/she will make a PR for it :] Thanx |
Reattempting felixmosh#762 with the typescript error ignored for this special case.
Retrying here: https://github.com/felixmosh/bull-board/pull/764/files Sorry about that. |
This hides the bullboard routes from openAPI schema generation. These routes don't have a schema defined, so they aren't useful in that context.