Enhanced Time Formatting for Short-duration Jobs #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanx for this PR 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior:
For jobs that complete in under 5 seconds, the system currently displays the duration as "less than 5 seconds". This approach obscures the details for tasks that finish in mere milliseconds.
Proposed Change:
To provide more granular information about job execution times, this pull request introduces an enhanced time formatting mechanism:
Jobs that take less than 1 second will display their duration in milliseconds (e.g., "320 miliseconds").
Jobs that take between 1 to 5 seconds will display their duration with a precision of two decimal places (e.g., "3.25 seconds").
Rationale:
This change ensures that users have a clear understanding of the job durations, especially for those that complete rapidly. It will be particularly valuable for performance monitoring and optimization efforts, where millisecond-level precision can be crucial.