improvement: Ensure jobs per page has a max of 50 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for this PR. I think that instead of adding an additional config, it is better to solve the max issue, it can be done by limiting num of chars or even with a verification of the max number, WDYT? |
tayclark
changed the title
showJobsPerPage UI Config option
|
Hi @felixmosh. Yea, that works. I've updated the PR |
|
Thanx for the change ,🙏🏼 |
|
Released in |
|
Thanks again @felixmosh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InputFieldmaxdoesn't prevent someone from inputting a higher value, it only limits how high the component will let you click the up arrow. Since a large page size w/ continuous polling on an open window could cause issues the jobs per page configuration will now be capped at 50 if an input > 50 is provided