Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow retrying completed jobs when using BullMQ #507

Merged
merged 3 commits into from
Jan 1, 2023
Merged

feat: Allow retrying completed jobs when using BullMQ #507

merged 3 commits into from
Jan 1, 2023

Conversation

dumbasPL
Copy link
Contributor

This PR adds support for retrying completed jobs when using the BullMQ adapter. Retrying completed jobs is not possible in bull, only in BullMq.

closes #506

This adds support for retrying completed jobs when using the BullMQ adapter. Retrying completed jobs is not possible in bull, only in BullMq.
@felixmosh
Copy link
Owner

Hi @dumbasPL
Can we make it possible to fake retries of completed jobs for bull as well?

@dumbasPL
Copy link
Contributor Author

Changes implemented, please review.

Hi @dumbasPL Can we make it possible to fake retries of completed jobs for bull as well?

Do we want to do that? So far this project wasn't trying to do things that aren't already natively supported. Doing this without making it obvious to the user what's actually going to happen might introduce unnecessary confusion and a lot of potential bugs.

How would we even go about doing this? When retrying jobs stuff like the job id remains constant. How about user-defined job IDs? Should we remove the job before adding a new one? How about repeated jobs? How about the attempts counter?

Personally, I think this is a terrible idea. A lot of ambiguity and unexpected behavior.

@felixmosh felixmosh merged commit dd7e3eb into felixmosh:master Jan 1, 2023
@felixmosh
Copy link
Owner

Thank you for this PR

@felixmosh
Copy link
Owner

Released in v4.10.0

@dumbasPL dumbasPL deleted the feat-506 branch January 1, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Retry completed jobs
2 participants