-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow retrying completed jobs when using BullMQ #507
Conversation
This adds support for retrying completed jobs when using the BullMQ adapter. Retrying completed jobs is not possible in bull, only in BullMq.
Hi @dumbasPL |
Changes implemented, please review.
Do we want to do that? So far this project wasn't trying to do things that aren't already natively supported. Doing this without making it obvious to the user what's actually going to happen might introduce unnecessary confusion and a lot of potential bugs. How would we even go about doing this? When retrying jobs stuff like the job id remains constant. How about user-defined job IDs? Should we remove the job before adding a new one? How about repeated jobs? How about the attempts counter? Personally, I think this is a terrible idea. A lot of ambiguity and unexpected behavior. |
Thank you for this PR |
Released in |
This PR adds support for retrying completed jobs when using the BullMQ adapter. Retrying completed jobs is not possible in bull, only in BullMq.
closes #506