Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move React development dependencies to devDependecies #317

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Move React development dependencies to devDependecies #317

merged 1 commit into from
Aug 12, 2021

Conversation

koresar
Copy link
Contributor

@koresar koresar commented Aug 12, 2021

We have a backend app. Which is small. But for some reason we have a couple of hundred React modules installed in production, in a little pure web server (soon to be a little AWS lambda).

Looks like @bull-board/ui have the UI inside the NPM gzip bundle: /dist/static/. This bundle already contains React dependencies, compiled, minified, bundled.

We identified the problem. The @radix-ui/ things are not production dependencies. They are build-time dependencies (aka devDependencies in NPM).

This PR decreased the node_modules by

See for yourself:

npx howfat -r tree @bull-board/ui

Please, publish the @bull-board/ui with this little fix. The little servers across the world will be thankful. :)

@felixmosh
Copy link
Owner

Thank tou 🙏🏼
I always forget the the ui is published compiled ,😅

@felixmosh felixmosh merged commit 00b9973 into felixmosh:master Aug 12, 2021
@felixmosh
Copy link
Owner

Released in v3.5.1

@koresar
Copy link
Contributor Author

koresar commented Aug 12, 2021

Wow Wow Wow! Why so fast? Unprecedented publishing speed. :) thank you

@koresar
Copy link
Contributor Author

koresar commented Aug 12, 2021

Here is the difference.

Before

$ howfat @bull-board/ui
Dependencies: 78
Size: 4.6mb
Files: 2347

After

$ howfat @bull-board/ui
Dependencies: 3
Size: 1.77mb
Files: 1152

78->3 dependencies 👍

@felixmosh
Copy link
Owner

Thank you for caring about the lib :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants