Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a filter input to the queue menu #313

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Added a filter input to the queue menu #313

merged 4 commits into from
Aug 6, 2021

Conversation

Jivings
Copy link
Contributor

@Jivings Jivings commented Aug 6, 2021

I have a lot of queues to manage in my bull-board dashboard (around 200-300 queues). I know the names of each of them but because of the truncation in the sidebar menu I can't just cmd+f search for the one I'm looking for.

So I added this little change to the Menu that allows me to filter the queues that appear on the left so I can find the one I'm looking for.

image

image

Let me know what you think, happy to tweak the UX if you have something else in mind.

Cheers!

Copy link
Owner

@felixmosh felixmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🙏🏼

It looks really great.

packages/ui/src/components/Menu/Menu.module.css Outdated Show resolved Hide resolved
@felixmosh
Copy link
Owner

felixmosh commented Aug 6, 2021

I will tweek the UI a bit so it will fit more, and then publish it.

In addition, I would like to show the search if the list is long (more than 5 queues)
OK?

@felixmosh felixmosh self-requested a review August 6, 2021 11:46
@felixmosh felixmosh merged commit c2092dc into felixmosh:master Aug 6, 2021
@Jivings
Copy link
Contributor Author

Jivings commented Aug 6, 2021

Yep sounds good to me!

@Jivings
Copy link
Contributor Author

Jivings commented Aug 6, 2021

I pushed the fixes you requested too, don't miss those commits.

@felixmosh
Copy link
Owner

Final result
image

Thank you for this feature 🙏🏼

@Jivings
Copy link
Contributor Author

Jivings commented Aug 6, 2021

Thanks for the quick turnaround! Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants