-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add addQueue and removeQueue methods #278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for sharing this UI @felixmosh - when you get a chance can you take a look at this PR? |
@ejhayes thank you for the PR. |
Should be fixed now @felixmosh |
Thank you 🙏 @ejhayes, Your changes were published at |
Wonderful, thank you @felixmosh! |
felixmosh
pushed a commit
that referenced
this pull request
May 28, 2021
* feat: add addQueue and removeQueue methods. Co-authored-by: Felix Mosheev <[email protected]> (cherry picked from commit c4b6763)
felixmosh
added a commit
that referenced
this pull request
May 29, 2021
* Reformat the code when semicolons enabled * Start of mono-repo refactor * Finish initial implementation of mono-repo mode * Add example with-express * Change author * Update express examples * fix api path * Add fastify adapter * Add fastify example * Add hapi adapter * Add hapi example * Change readmes * Update main README.md * Fix blurry fonts (cherry picked from commit f1d9b04) * Reformat theme.css * Remove eslint-plugin-prettier since it formats differently then prettier it self (cherry picked from commit ce93b4c) * Cleanup package.json * Change prettier config * Fix lint * Cleanup root * chore(deps): bump dns-packet from 1.3.1 to 1.3.4 (#279) Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Mosheev <[email protected]> (cherry picked from commit efdbd4c) * Add release-it-yarn-workspaces * Drop support for node 10 * feat: add addQueue and removeQueue methods (#278) * feat: add addQueue and removeQueue methods. Co-authored-by: Felix Mosheev <[email protected]> (cherry picked from commit c4b6763) * Fix tests Move to use mock of ioredis instead of dockest * Reformat the code * Update lock * Change to ci env * Change install command * Switch build & tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eric Hayes <[email protected]>
felixmosh
added a commit
that referenced
this pull request
Jun 28, 2021
* feat: add addQueue and removeQueue methods. * chore: fix linting errors. * fix: lint issues Co-authored-by: Felix Mosheev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds methods to add/remove queues. The current implementation currently only allows the ability to set multiple queues or replace all queues.