-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Collapse job data #529
Comments
It probably will solve the performance issue, since highlighting large json is a demanding task, but It should be only a UX consideration. If your json data is huge, you should use data formatter in order to reduce the size of the JSON, the app won't be able to reduce it for you. But this is totally a nice UX optimization, it should be settings configurable. |
I face the same issue. I write a lot of data and some payloads are huge and they completely break the Dashboard. Even when they are not being processed anymore or they should be on the second page, I cannot get it to load without my Browser killing the tab. Only solution to make it usable again currently is to just kill the redis-container, delete and recreate it, which works and is fine in this use-case, but probably not in others. |
@bennet-esyoil did you tried the data formatter, in order to reduce the data payload? |
That could be a option. I'll need to figure out first if the data needs to be shown there, normally I wouldn't want to check each entry in the queues, but for debugging it's perfect. Anyways, I'll talk back with my team and see if it's a viable option. Thanks for the suggestion. Update: I was able to implement the data-formatter and just remove the huge elements. We do not really have the need to visualize it at that point, and can still get it back later if we decide to. So yep, the data-formatter is the correct solution in my case. |
We are running into the same issue here! My recommendation would be to just create a setting (in the top right menu), where you can collapse the JSONs by default. Like this, hopefully, the DOM should not crash and it is then the user's job to just open the JSON (job data) for a single job as needed. |
@Twisterking will able to prepare a PR for this? |
Maybe, not sure yet! I was not aware of the |
I'll add an additional optimization which will use webworker if available for highlighting code |
@sroettering can you test |
At first glance it looks very nice! Would have expected to be able to collapse the data again, but I guess it's ok like this. Performance is also good in my first test. |
Did you tested the board without the collapse state? |
yes, it's much better now. Also the paging is really fast as well! |
I have queues with large payloads and the bull board pages load very slowly. I did not investigate why it is so slow. I suspect rendering the job data as json takes for ever. Thus it would be nice if large objects/arrays would be auto-collapsed when rendering (similar to collapsing code lines in IDEs). This would also make job data more readable because you don't have to scroll down thousands of lines to see the properties that come after these big chunks. So collapsible json would be a nice regardless if it fixes the performance or not.
The text was updated successfully, but these errors were encountered: