Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Customize header image / text #431

Closed
jamesdwilson opened this issue Jul 14, 2022 · 12 comments
Closed

Feature request: Customize header image / text #431

jamesdwilson opened this issue Jul 14, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@jamesdwilson
Copy link

It would be nice to be able to pass in alternative text or CSS class or image for the header.

@felixmosh
Copy link
Owner

felixmosh commented Jul 15, 2022

It would be nice, but it is not so simple.

Think that you will need to change the favicon as well.
How do you think that the best option will be?
Allowing users to pass castomization object with logo url?

@felixmosh felixmosh added the enhancement New feature or request label Jul 15, 2022
@jamesdwilson
Copy link
Author

jamesdwilson commented Jul 15, 2022 via email

@felixmosh
Copy link
Owner

It can be possible :]
I have a list of features that I need to add before this one, If you really want this, I'll more than happy to review a PR :]

@davejhilton
Copy link

Just came here to say that I agree, this would be a great feature—and to share why it would be useful in my case.

My use case would be: to add some way to visually distinguish between different instances of bull-board.

For example, we have separate deployments of bullmq for our development/staging/production environments, and we have bull-board running on each, to view/interact with the different queues in each environment. I often find that I have multiple browser tabs open with bull-board in different environments, and it can be quite easy to mistake one environment's dashboard for another. So having a way to make one say "Production" somewhere at the top vs "Development"—possibly using different colors even—would make a meaningful difference.

@felixmosh
Copy link
Owner

@davejhilton thank you for sharing your use-case, I think that allowing to pass custom ejs file will expose too much of the internals.

Each minor / patch version you will need to update your ejs file (asset hashes)...
Maybe, it is better to allow to pass env config, which if exists the board render it (with some style), WDYT?

@felixmosh
Copy link
Owner

BTW, you can modify the final html as you wish by providing a custom ServerAdapter, for example, for Express adapter,
You can copy the one that is provided, and change the viewHandler here

const viewHandler = (_req: Request, res: Response) => {
res.render(name, { basePath: this.basePath });
};

@jamesdwilson
Copy link
Author

jamesdwilson commented Jul 17, 2022 via email

@davejhilton
Copy link

BTW, you can modify the final html as you wish by providing a custom ServerAdapter, for example, for Express adapter, You can copy the one that is provided, and change the viewHandler

Oh, I hadn't thought of that! This should actually work perfectly for the (minimal) changes I need. Thanks!

@felixmosh
Copy link
Owner

felixmosh commented Jul 19, 2022

I'm closing this issue since I don't think that it is a good practice to expose internals

@jamesdwilson
Copy link
Author

Vote to leave open and allow passing in custom title, CSS class of logo, image url.

@felixmosh felixmosh reopened this Jul 19, 2022
@felixmosh
Copy link
Owner

Lets vote for it :]

@felixmosh
Copy link
Owner

Closing this since there is no demand for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants