Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue pause / resume feature #214

Closed
sajov opened this issue Jan 16, 2021 · 8 comments · Fixed by #309
Closed

Queue pause / resume feature #214

sajov opened this issue Jan 16, 2021 · 8 comments · Fixed by #309

Comments

@sajov
Copy link

sajov commented Jan 16, 2021

Hi, thanks for this board.
Bull is pretty new to me. While discovering the queue api makes me wondering why there is no pause and resume a queue feature?
May be i miss something.
If it makes senes i can do a PR.

@felixmosh
Copy link
Owner

There is no good reason for these missing actions, I guess that it can be added to relevant statuses.

PR's are welcome :]

@ccollie
Copy link

ccollie commented Jan 17, 2021

I guess that it can be added to relevant statuses.

pause and resume are queue-global (at least in bullmq)

@sajov
Copy link
Author

sajov commented Jan 17, 2021

Yes it's queue-global and i thought to add it on the left queue menu

@sajov
Copy link
Author

sajov commented Jan 17, 2021

There are missing type definition for isPaused therefore i had to made a PR DefinitelyTyped/DefinitelyTyped#50685

I forked and and got it working. https://github.com/sajov/bull-board

This is how it looks like for now. Any suggestion?
default
pause
resume
thx

@ccollie
Copy link

ccollie commented Jan 17, 2021

Looks good to me

@felixmosh
Copy link
Owner

I don't think that this is the right place for it, someone can click on the pause/resume button by mistake.

In my opinion, it is better to place the "queue actions" above the tabs inside the queue page, wdyt?

@sajov
Copy link
Author

sajov commented Jan 18, 2021

@felixmosh thats a good Point! thx
Still waiting for neseccary type PR, so i will move this actions. A Suggestion where exactly?
Got it, you suggested the right place already.

sajov pushed a commit to sajov/bull-board that referenced this issue Jan 19, 2021
felixmosh added a commit that referenced this issue Aug 3, 2021
* feat: add pause / resume on queue level, closes #214
@felixmosh
Copy link
Owner

This feature is added at v3.4.0.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants