-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Job progress count instead of percentage #17
Comments
hey @sephirothmk, thank you for reporting the issue, I do see the problem 😅 the docs for bull specify the progress to be a number between 0 and 100 as such: https://github.com/OptimalBits/bull/blob/develop/REFERENCE.md#jobprogress So I wonder if in this case there's something that should be done application wise, instead of in bull-board I actually noticed we handle cases when I'll open a PR with the fix |
jobs might have progress reports with values that are bigger than 100 this at least prevents the progress bar to break and instead show only the number fixes #17
jobs might have progress reports with values that are bigger than 100 this at least prevents the progress bar to break and instead show only the number fixes #17
Hello.
First of all, thank you for making a nice and clean interface for bull. I use it in my project that syncs data between databases. I do the work using batches, so I never know the max value of things that need processing in order to calculate the percentage. So if i do
job.progress(item.count)
where item.count is for example 4235 items, the frontend interface will go crazy because the green progressbar will bestyle="width: 4235%"
.What im proposing is a simple check, something along the lines of:
if (job.progress > 100) // Don't render class="progress-bar", style="width: 4235%" and the % sign
Thanks in advance
The text was updated successfully, but these errors were encountered: