Skip to content

Commit

Permalink
code-test for the designers_profile check
Browse files Browse the repository at this point in the history
that was temporarily commented-out waiting for the merge of google/fonts#3696
  • Loading branch information
felipesanches committed Aug 25, 2021
1 parent 8ec6937 commit 92ed5be
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions tests/profiles/googlefonts_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3814,12 +3814,10 @@ def test_check_metadata_designer_profiles():
assert_results_contain(check(font),
FAIL, "multiple-designers")

# FIXME: Uncomment this code-test once we merge this google/fonts PR:
# https://github.com/google/fonts/pull/3696
# # This reference Merriweather font family lists "Sorkin Type" in its METADATA.pb file.
# # And this foundry has a good profile on the catalog.
# font = TEST_FILE("merriweather/Merriweather-Regular.ttf")
# assert_PASS(check(font))
# This reference Merriweather font family lists "Sorkin Type" in its METADATA.pb file.
# And this foundry has a good profile on the catalog.
font = TEST_FILE("merriweather/Merriweather-Regular.ttf")
assert_PASS(check(font))

# TODO: FAIL, "mismatch"
# TODO: FAIL, "link-field"
Expand Down

0 comments on commit 92ed5be

Please sign in to comment.