Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FoundryVTT version to 12.325 #981

Merged
merged 2 commits into from
May 31, 2024
Merged

Bump FoundryVTT version to 12.325 #981

merged 2 commits into from
May 31, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented May 31, 2024

πŸ—£ Description

Support FoundryVTT version 12.325.
Makes references to presigned URLs provider-agnostic.

πŸ’­ Motivation and context

New hotness. 🌢️
FoundryVTT moved from AWS S3 to Cloudflare R2.

πŸ§ͺ Testing

Locally and in CI.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

felddy added 2 commits May 31, 2024 09:54
FoundryVTT is now using cloudflare's R2 object storage.
Remove references to AWS S3, and use a generic term: "presigned URL".

Normalize usage of `presigned` (not `pre-signed`).

See:
- https://developers.cloudflare.com/r2/api/s3/presigned-urls/
@felddy felddy self-assigned this May 31, 2024
@felddy felddy merged commit 920fac9 into develop May 31, 2024
42 checks passed
@felddy felddy deleted the release/12.325.0 branch May 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant