Properly utilize exec in helper scripts #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR modifies the way that
launcher.sh
and the ultimatenode
processes are created.💭 Motivation and context
The
enterypoint.sh
script will now callexec su-exec
instead of justsu-exec
whenstarting the
launcher.sh
. I had wrongly assumed thatsu-exec
was alsoexec
ing.Similarly
launcher.sh
will now useexec env
... instead ofenv
to startnode
.The motivation is to get the
node
process as PID 1 in the container, thus simplifying signal handling.I went this route instead of implementing traps or using an init process as it was my original design goal to have a simple, single-process container.
Closes #813
🧪 Testing
Tested locally on my development box. I was able to verify that the process list is collapsed as designed.
Before:
After:
Also tested in CI.
✅ Pre-approval checklist
to reflect the changes in this PR.