Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for unset repository secrets #324

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

felddy
Copy link
Owner

@felddy felddy commented Apr 18, 2022

🗣 Description

This PR adds jobs to the build workflow that verifies that Docker and Foundry secrets are present.
If the secrets are not available, the jobs that require the secrets will be skipped, and informative
error messages are emitted.

💭 Motivation and Context

PRs from forks do not have access to repository secrets.
The CI UI did not make it obvious why the jobs were failing.
These extra jobs clearly throw errors into the annotations describing the problem.

🧪 Testing

Tested with GitHub actions by unsetting the FOUNDRY_USERNAME.

📷 Screenshots (if appropriate)

image

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow project standards.
  • All relevant repo and/or project documentation has been updated to reflect
    the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this Apr 18, 2022
@felddy felddy merged commit 41c7f2d into develop Apr 18, 2022
@felddy felddy deleted the improvement/workflow_secret_check branch April 18, 2022 23:26
Sallenmoore pushed a commit to Sallenmoore/foundryvtt-docker that referenced this pull request Jun 18, 2023
…_check

Add checks for unset repository secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant