Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden GitHub Actions workflows #323

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

felddy
Copy link
Owner

@felddy felddy commented Apr 18, 2022

🗣 Description

This PR hardens the GitHub Actions workflows by:

  • installing a hardened runner
  • pinning dependencies to their hash
  • limiting the default permissions of the GITHUB_TOKEN

💭 Motivation and Context

These changes were suggested by the security alerts of the Scorecard code security scanner.

🧪 Testing

Testing only in CI. These changes need to be in the default branch before they can be fully tested.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow project standards.
  • All relevant repo and/or project documentation has been updated to reflect
    the changes in this PR.
  • Tests have been added to cover the changes in this PR.
  • All new and existing tests pass.

@felddy felddy merged commit c2d7e87 into develop Apr 18, 2022
@felddy felddy deleted the improvement/workflow_security branch April 18, 2022 21:47
Sallenmoore pushed a commit to Sallenmoore/foundryvtt-docker that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant