feat: EquatableConfig for global stringify configuration #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 45 59 +14
=========================================
+ Hits 45 59 +14
Continue to review full report at Codecov.
|
jorgecoca
approved these changes
May 29, 2020
zepfietje
reviewed
May 29, 2020
| class EquatableConfig { | ||
| /// Global [stringify] setting for all [Equatable] instances. | ||
| /// If [stringify] is overridden for a particular [Equatable] instance, | ||
| /// then the local [stringify] value takes precendence |
|
good!!!!!!!!!!!!!!thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Addresses #68 #60 #65
stringifycan be configured globally for allEquatableinstances viaEquatableConfigIf
stringifyis overridden for a specificEquatableclass, then the value ofEquatableConfig.stringifyis ignored.In other words, the local configuration always takes precedence over the global configuration.
Todos
Impact to Remaining Code Base
New feature which will be included in v1.2.0 of
Equatable.