Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fr translations for architecture, getting-started, index, testing, and why-bloc #4273

Merged
merged 11 commits into from
Nov 16, 2024

Conversation

Badlix
Copy link
Contributor

@Badlix Badlix commented Nov 4, 2024

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Détails

Add the french translation for :

  • index.mdx
  • getting-started.mdx
  • why-bloc.mdx
  • architecture.mdx
  • testing.mdx

@Badlix Badlix requested a review from felangel as a code owner November 4, 2024 19:05
@felangel felangel added the translation Translation topic label Nov 4, 2024
@felangel
Copy link
Owner

Looks like we just need to run npm run format to fix the formatting.

Copy link
Collaborator

@vmichalak vmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, it's a lot of work to translate the documentation.

Since I am French, I took the liberty of highlighting the typos i've see in your PR. All comments marked as suggestion are more to make the documentation more "french native" / "natural" to read in french. Don't hesitate to comment in case of doubt :)

docs/src/content/docs/fr/architecture.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/architecture.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/architecture.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/architecture.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/architecture.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/why-bloc.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/why-bloc.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/why-bloc.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/why-bloc.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/why-bloc.mdx Outdated Show resolved Hide resolved
@felangel felangel changed the title docs: add french translation for index, getting-started, why-bloc, architecture et testing mdx files. docs: add fr translations for architecture, getting-started, index, testing, and why-bloc Nov 16, 2024
felangel
felangel previously approved these changes Nov 16, 2024
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contributions and @vmichalak for the review I really appreciate it 💙 🙏

@felangel felangel merged commit f8cb5d9 into felangel:master Nov 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translation topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants