Skip to content

Commit

Permalink
root: require +opengl when +aqua is on (spack#47349)
Browse files Browse the repository at this point in the history
According to root-project/root#7160, if
`-Dcocoa=ON` build must also be configured with `-Dopengl=ON`, since
otherwise the build encounters missing includes. This is/was a silent
failure in ROOT CMake, but I believe has been made an explicit failure
some time this year.
  • Loading branch information
paulgessinger authored Nov 2, 2024
1 parent b8461f3 commit 55918c3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions var/spack/repos/builtin/packages/root/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,8 @@ class Root(CMakePackage):
# Incompatible variants
if sys.platform == "darwin":
conflicts("+opengl", when="~x ~aqua", msg="root+opengl requires X or Aqua")
# https://github.com/root-project/root/issues/7160
conflicts("+aqua", when="~opengl", msg="+aqua requires OpenGL to be enabled")
else:
conflicts("+opengl", when="~x", msg="root+opengl requires X")
conflicts("+math", when="~gsl", msg="root+math requires GSL")
Expand Down

0 comments on commit 55918c3

Please sign in to comment.