Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter prefix #672

Closed
aancel opened this issue Nov 3, 2015 · 4 comments
Closed

Exporter prefix #672

aancel opened this issue Nov 3, 2015 · 4 comments

Comments

@aancel
Copy link
Contributor

aancel commented Nov 3, 2015

Following the test written by @gdolle (testsuite/feelts/test_bdf3.cpp), we noticed some issues regarding the prefix used by the exporter:
An example would be (from @gdolle's code):

# First create an exporter with the test_bdf prefix
# This will create the initial timeset with the corresponding prefix
auto e = exporter( _mesh=mesh, _name="test_bdf" );
...
# Further calls to setPrefix won't modify the prefix of the timeset 
# after this initial call, because the setPrefix function does not update 
# the prefix of the latest timeset.
e->setPrefix( prefix )

Actually and currently, this is working with the Ensight Gold exporter because I made modifications to actually use the prefix set to the exporter and not the name of the timeset, but I think it would be a better idea to totally switch to using the name of the timeset.

The function setPrefix( name ) currently only store the value for the prefix. Wouldn't it be a better idea to directly set the value of the most recent timeset rather than storing the prefix ? Maybe we can also add a new setPrefix( ts_id, name ) that would allow to modify the prefix for other timesets (in case we would be using several of them)

@prudhomm
Copy link
Member

prudhomm commented Nov 3, 2015

I would have to have a closer look. I wrote that a long time ago. I need to refresh my memories.

@aancel
Copy link
Contributor Author

aancel commented Nov 4, 2015

I can take care of this and the associated modifications in the exporters, if you validate the change. I think it would make the code of the exporters cleaner.

@prudhomm
Copy link
Member

prudhomm commented Nov 4, 2015

sure, do that in a branch + PR

@prudhomm
Copy link
Member

prudhomm commented Nov 4, 2015

@aancel Please discuss here or the branch/PR the changes before hand rather than after.

aancel added a commit that referenced this issue Nov 4, 2015
- small bump to initiate PR
- Added function to set timeset name
@aancel aancel mentioned this issue Nov 4, 2015
5 tasks
aancel added a commit that referenced this issue Nov 5, 2015
- Updated setName in timeset
- Change timeset name when setting prefix in exporter with setPrefix
- No longer use prefix in ensight gold exporter (Only sos remains)
aancel added a commit that referenced this issue Nov 5, 2015
- Removed debug cout
prudhomm added a commit that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants