-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporter prefix #672
Labels
Comments
I would have to have a closer look. I wrote that a long time ago. I need to refresh my memories. |
I can take care of this and the associated modifications in the exporters, if you validate the change. I think it would make the code of the exporters cleaner. |
sure, do that in a branch + PR |
@aancel Please discuss here or the branch/PR the changes before hand rather than after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following the test written by @gdolle (testsuite/feelts/test_bdf3.cpp), we noticed some issues regarding the prefix used by the exporter:
An example would be (from @gdolle's code):
Actually and currently, this is working with the Ensight Gold exporter because I made modifications to actually use the prefix set to the exporter and not the name of the timeset, but I think it would be a better idea to totally switch to using the name of the timeset.
The function
setPrefix( name )
currently only store the value for the prefix. Wouldn't it be a better idea to directly set the value of the most recent timeset rather than storing the prefix ? Maybe we can also add a newsetPrefix( ts_id, name )
that would allow to modify the prefix for other timesets (in case we would be using several of them)The text was updated successfully, but these errors were encountered: