-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running using tmt
#123
Conversation
ea36d39
to
4e65131
Compare
@lzaoral, could you please review this PR? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test logs contain following errors:
:: [ 12:14:36 ] :: [ PASS ] :: NEW_FOLLOWER link: /tmp/tmp.nmaS2fKnwG/link_a/follower_a (Expected 0, got 0)
basename: missing operand
Try 'basename --help' for more information.
:: [ 12:14:36 ] :: [ PASS ] :: Mode: (Assert: 'auto' should equal 'auto')
...
./test-alternatives.sh: line 310: rlPhase: command not found
Unfortunately, beakerlib
is not compatible with set -e
so we can't catch such errors this way. :/
Remove dependency on beakerlib for distros other than Fedora. Tests will be executed using tmt and tf on CentOS Stream and RHEL.
@lzaoral Thank you for noticing this error! It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update, @jamacku! Unfortuantely, the basename
error in the last phase is still present:
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: Dynamic Follower Remove
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [ 13:12:53 ] :: [ BEGIN ] :: NEW link: link_a Prio: 10 Family: :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --install /tmp/tmp.Q0AgP9k3Z8/main_link TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main 10 --slave /tmp/tmp.Q0AgP9k3Z8/follower_link STEST /tmp/tmp.Q0AgP9k3Z8/link_a/follower '
:: [ 13:12:53 ] :: [ PASS ] :: NEW link: link_a Prio: 10 Family: (Expected 0, got 0)
:: [ 13:12:54 ] :: [ BEGIN ] :: NEW_FOLLOWER link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --add-slave TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main /tmp/tmp.Q0AgP9k3Z8/follower_link STEST /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a'
:: [ 13:12:54 ] :: [ PASS ] :: NEW_FOLLOWER link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a (Expected 0, got 0)
:: [ 13:12:54 ] :: [ BEGIN ] :: NEW_FOLLOWER link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --remove-slave TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main STEST'
:: [ 13:12:54 ] :: [ PASS ] :: NEW_FOLLOWER link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a (Expected 0, got 0)
basename: missing operand
Try 'basename --help' for more information.
:: [ 13:12:54 ] :: [ PASS ] :: Mode: (Assert: 'auto' should equal 'auto')
:: [ 13:12:54 ] :: [ PASS ] :: Highest Priority: (Assert: 'link_a' should equal 'link_a')
:: [ 13:12:54 ] :: [ PASS ] :: Selected: (Assert: 'link_a' should equal 'link_a')
:: [ 13:12:54 ] :: [ PASS ] :: Follower: (Assert: '' should equal '')
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: Duration: 1s
:: Assertions: 7 good, 0 bad
:: RESULT: PASS (Dynamic Follower Remove)
No description provided.