Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running using tmt #123

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Add support for running using tmt #123

merged 7 commits into from
Jan 17, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jan 16, 2024

No description provided.

tests/alternatives/test-alternatives.sh Dismissed Show dismissed Hide dismissed
tests/alternatives/test-alternatives.sh Dismissed Show dismissed Hide dismissed
tests/alternatives/test-alternatives.sh Dismissed Show dismissed Hide dismissed
tests/alternatives/test-alternatives.sh Dismissed Show dismissed Hide dismissed
tests/alternatives/test-alternatives.sh Fixed Show fixed Hide fixed
tests/alternatives/test-alternatives.sh Fixed Show fixed Hide fixed
@jamacku jamacku marked this pull request as ready for review January 17, 2024 12:11
@jamacku
Copy link
Member Author

jamacku commented Jan 17, 2024

@lzaoral, could you please review this PR? Thanks

@jamacku jamacku requested a review from lnykryn January 17, 2024 12:12
@jamacku jamacku added the ci CI related stuff label Jan 17, 2024
Copy link
Contributor

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test logs contain following errors:

:: [ 12:14:36 ] :: [   PASS   ] :: NEW_FOLLOWER	link: /tmp/tmp.nmaS2fKnwG/link_a/follower_a (Expected 0, got 0)
basename: missing operand
Try 'basename --help' for more information.

:: [ 12:14:36 ] :: [   PASS   ] :: Mode: (Assert: 'auto' should equal 'auto')
...
./test-alternatives.sh: line 310: rlPhase: command not found

Unfortunately, beakerlib is not compatible with set -e so we can't catch such errors this way. :/

.packit.yml Outdated Show resolved Hide resolved
tests/alternatives/main.fmf Outdated Show resolved Hide resolved
tests/alternatives/main.fmf Show resolved Hide resolved
Remove dependency on beakerlib for distros other than Fedora.
Tests will be executed using tmt and tf on CentOS Stream and RHEL.
@jamacku
Copy link
Member Author

jamacku commented Jan 17, 2024

The test logs contain following errors:

./test-alternatives.sh: line 310: rlPhase: command not found

@lzaoral Thank you for noticing this error! It should be fixed now.

Copy link
Contributor

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, @jamacku! Unfortuantely, the basename error in the last phase is still present:

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Dynamic Follower Remove
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 13:12:53 ] :: [  BEGIN   ] :: NEW	link: link_a	Prio: 10	Family:  :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --install /tmp/tmp.Q0AgP9k3Z8/main_link TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main 10 --slave /tmp/tmp.Q0AgP9k3Z8/follower_link STEST /tmp/tmp.Q0AgP9k3Z8/link_a/follower '
:: [ 13:12:53 ] :: [   PASS   ] :: NEW	link: link_a	Prio: 10	Family:  (Expected 0, got 0)
:: [ 13:12:54 ] :: [  BEGIN   ] :: NEW_FOLLOWER	link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --add-slave TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main /tmp/tmp.Q0AgP9k3Z8/follower_link STEST /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a'
:: [ 13:12:54 ] :: [   PASS   ] :: NEW_FOLLOWER	link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a (Expected 0, got 0)
:: [ 13:12:54 ] :: [  BEGIN   ] :: NEW_FOLLOWER	link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a :: actually running 'alternatives --altdir /tmp/tmp.G6lNXfm3rY --admindir /tmp/tmp.Cj5OGoKIB9 --remove-slave TEST /tmp/tmp.Q0AgP9k3Z8/link_a/main STEST'
:: [ 13:12:54 ] :: [   PASS   ] :: NEW_FOLLOWER	link: /tmp/tmp.Q0AgP9k3Z8/link_a/follower_a (Expected 0, got 0)
basename: missing operand
Try 'basename --help' for more information.

:: [ 13:12:54 ] :: [   PASS   ] :: Mode: (Assert: 'auto' should equal 'auto')
:: [ 13:12:54 ] :: [   PASS   ] :: Highest Priority: (Assert: 'link_a' should equal 'link_a')
:: [ 13:12:54 ] :: [   PASS   ] :: Selected: (Assert: 'link_a' should equal 'link_a')
:: [ 13:12:54 ] :: [   PASS   ] :: Follower: (Assert: '' should equal '')
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 1s
::   Assertions: 7 good, 0 bad
::   RESULT: PASS (Dynamic Follower Remove)

@jamacku jamacku merged commit 812b295 into fedora-sysv:main Jan 17, 2024
12 of 13 checks passed
@jamacku jamacku deleted the tf branch January 17, 2024 14:09
@jamacku jamacku linked an issue Jun 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL10 - remove dependency on beakerlib
3 participants