Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

plugins: Text and whitespace fixes #11

Closed
wants to merge 1 commit into from

Conversation

dperpeet
Copy link
Contributor

If/Then sentences should now uniformly begin with a capital letter.
Also minor python whitespace cleanup.

The Cockpit ui plugin for setroubleshoot (wip: cockpit-project/cockpit#3962) would look better if the Messages started with capitalized letters.

Is there a way to preserve translations? I don't want to break all the work that's been done for minor changes.

If/Then sentences should now uniformly begin with a capital letter.

Also minor python whitespace cleanup.
@bachradsusi
Copy link
Member

Thanks for the patch.

if_text is always wrapped with _("If ") therefore if sentences should not start with a capital letter.

I would rather have two patches here, one for the text changes and other for whitespace fixes.

Please use fedora-selinux:python3 branch as a development base. master is considered as legacy python2 while all new things goes to python3. We need to document it and probably change the structure to be more consistent.

As for the translations, we use fedora.zanata.org. It should be feasible to merge old translations with new strings. However I need to check it and find out how.

@dperpeet
Copy link
Contributor Author

Interesting.

if_text is always wrapped with _("If ") therefore if sentences should not start with a capital letter.

Via dbus api you deliver the text including the "If ", correct? Am I correct to assume that the "if" text in plugins should start with lower case? Or is that done programmatically?

What about conditions for 'then' and 'do'? The 'do' part seems especially heterogeneous.

I will change this pr and split the modifications.

@dperpeet dperpeet closed this Mar 24, 2016
@bachradsusi
Copy link
Member

"If " is added in browser and using DBUS api as well.

We need to change strings to already contain "If " on the beginning since sometime is simply not possible to put "If" in other language to the beginning of a sentence.

@bachradsusi
Copy link
Member

@bachradsusi
Copy link
Member

bachradsusi commented Aug 22, 2017

The change described in #11 (comment) is applied in master branch now - 98c2ad7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants