addbuilds and removebuilds #3125
Conversation
tdawson
force-pushed
the
addbuilds
branch
2 times, most recently
from
fed8e96 to
1454f88
Compare
|
Change LGTM, but you might want to squash your commit to a single commit. |
bodhi/client/__init__.py
Outdated
| @@ -98,6 +98,8 @@ def _set_logging_debug(ctx, param, value): | |||
| new_edit_options = [ | |||
| click.option('--user'), | |||
| click.option('--password', hide_input=True), | |||
| click.option('--addbuilds', help='Add Comma-separated list of build nvr'), | |||
There was a problem hiding this comment.
I just realized that this are the shared options between the update new and the update edit command. I think these options are only really useful for edit. So they should probably be added directly to the edit method. What do you think ?
see https://github.com/fedora-infra/bodhi/blob/develop/bodhi/client/__init__.py#L440 for an example.
|
I am not 100% sure why but it seems that this change broke some existing tests. You can run |
|
I needed to remove addbuilds and removebuilds from kwargs each time. |
|
I am sorry I just thought about one last things 🤦♂️ .We will want to update the man page of the bodhi cli with the new options. https://github.com/fedora-infra/bodhi/blob/develop/docs/user/man_pages/bodhi.rst Other than that I ran the tests locally and everything looked good 👍 |
Signed-off-by: Troy Dawson <[email protected]>
|
Good catch. |
|
👍 |
|
In the future, please don't merge pull requests unless the CI passes (unless the pull request is critical, like a security issue or something along those lines). When CI isn't passing, we should focus on fixing that and hold all pull requests from merging until that issue is resolved. |
|
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
|
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
New edit options for bodhi client
Given a comma seperated list of build nvr's, it adds, or removes, those builds from the update.