Drop support for Python 2 in bodhi.server. #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowlofeggs
added
High priority
abompard
reviewed
Dec 19, 2018
| @@ -12,21 +12,18 @@ pull_request_rules: | |||
| - status-success=f28-flake8 | |||
| - status-success=f28-pydocstyle | |||
| - status-success=f28-python2-unit | |||
There was a problem hiding this comment.
You can drop the unit tests too, no?
There was a problem hiding this comment.
We can't yet, because the client still supports Python 2.
There was a problem hiding this comment.
Python 2 support is planned to be dropped from the client in #2856. I am waiting just a bit to see if my dependencies will stop using it before making that change.
bowlofeggs
force-pushed
the
2759
branch
7 times, most recently
from
9c0c9c4 to
df7d153
Compare
|
What is the pourpose of installing bodhi for py2 and py3? |
|
On Thu, 2018-12-20 at 12:23 -0800, Sebastian Wojciechowski wrote:
What is the pourpose of installing bodhi for py2 and py3?
I assume that one of the reasons is bodhi-client for py2.
Are there any others?
Yes, it's because the client still supports Python 2 for now. See
#2856.
|
Python 2 support goes away upstream in two months, so it is time to embrace the glorious future. This change also drops support for pkgdb integration, since the pkgdb client library does not support Python 3. Mock imports were moved to be grouped with the stdlib imports as per PEP-8, since mock is part of the stdlib in Python 3. fixes fedora-infra#1970 fixes fedora-infra#2759 Signed-off-by: Randy Barlow <[email protected]>
|
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
|
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 support goes away upstream in two months, so it is time
to embrace the glorious future.
This change also drops support for pkgdb integration, since the
pkgdb client library does not support Python 3.
Mock imports were moved to be grouped with the stdlib imports as
per PEP-8, since mock is part of the stdlib in Python 3.
fixes #1970
fixes #2759
Signed-off-by: Randy Barlow [email protected]