-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bodhi manage releases #2652
Remove bodhi manage releases #2652
Conversation
1c73e02
to
08e8eea
Compare
As noted in #2420, we don't want to merge this until we are ready to make Bodhi 4.0.0, since it is backwards incompatible. |
@@ -11,114 +11,12 @@ Synopsis | |||
Description | |||
=========== | |||
|
|||
DEPRECATED: This utility has been deprecated. Please use ``bodhi releases`` instead. | |||
REMOVED: This utility has been removed. Please use ``bodhi releases`` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For when it's time to merge this PR, we should also delete this file. The more noticeable place to make a note of the files removal is the release notes (see docs/user/release_notes.rst
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a link in releases_notes.rst, so after removal the following info is shown after bdocs:
Warning, treated as error:
/home/vagrant/bodhi/docs/user/release_notes.rst:563:unknown document: man_pages/bodhi-manage-releases
Is it ok to change lines in release_notes.rst in legacy releases?
On Tue, 2018-10-09 at 13:29 -0700, Sebastian Wojciechowski wrote:
Is it ok to change lines in release_notes.rst in legacy releases?
Yeah I think that's OK in this case. We can leave the text but just
stop it from being a link.
|
9f39cb8
to
2e3970c
Compare
2e3970c
to
a98c979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a note to docs/user/release_notes.rst
in the backwards incompatible changes section.
Fixes fedora-infra#2420 Signed-off-by: Sebastian Wojciechowski <[email protected]>
a98c979
to
360c1b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
Fix #2420
Signed-off-by: Sebastian Wojciechowski [email protected]