Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bodhi manage releases #2652

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

sebwoj
Copy link
Collaborator

@sebwoj sebwoj commented Oct 7, 2018

Fix #2420

Signed-off-by: Sebastian Wojciechowski [email protected]

@sebwoj sebwoj requested a review from a team as a code owner October 7, 2018 11:58
@sebwoj sebwoj force-pushed the Remove_bodhi_manage_releases branch 2 times, most recently from 1c73e02 to 08e8eea Compare October 7, 2018 12:51
@bowlofeggs bowlofeggs added no-mergify Server CLI Issues pertaining to Bodhi's server command line tools Refactor Issues that are a refactor to improve maintainability for Bodhi Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release labels Oct 8, 2018
@bowlofeggs
Copy link
Contributor

As noted in #2420, we don't want to merge this until we are ready to make Bodhi 4.0.0, since it is backwards incompatible.

@@ -11,114 +11,12 @@ Synopsis
Description
===========

DEPRECATED: This utility has been deprecated. Please use ``bodhi releases`` instead.
REMOVED: This utility has been removed. Please use ``bodhi releases`` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For when it's time to merge this PR, we should also delete this file. The more noticeable place to make a note of the files removal is the release notes (see docs/user/release_notes.rst).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link in releases_notes.rst, so after removal the following info is shown after bdocs:

Warning, treated as error:
/home/vagrant/bodhi/docs/user/release_notes.rst:563:unknown document: man_pages/bodhi-manage-releases

Is it ok to change lines in release_notes.rst in legacy releases?

@bowlofeggs
Copy link
Contributor

bowlofeggs commented Oct 9, 2018 via email

@sebwoj sebwoj force-pushed the Remove_bodhi_manage_releases branch 2 times, most recently from 9f39cb8 to 2e3970c Compare December 11, 2018 23:08
@sebwoj sebwoj force-pushed the Remove_bodhi_manage_releases branch from 2e3970c to a98c979 Compare January 6, 2019 11:40
Copy link
Contributor

@bowlofeggs bowlofeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a note to docs/user/release_notes.rst in the backwards incompatible changes section.

Fixes fedora-infra#2420

Signed-off-by: Sebastian Wojciechowski <[email protected]>
@sebwoj sebwoj force-pushed the Remove_bodhi_manage_releases branch from a98c979 to 360c1b5 Compare January 8, 2019 17:02
Copy link
Contributor

@bowlofeggs bowlofeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 78609b5 into fedora-infra:develop Jan 14, 2019
@sebwoj sebwoj deleted the Remove_bodhi_manage_releases branch January 15, 2019 16:09
@bowlofeggs
Copy link
Contributor

This patch is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Refactor Issues that are a refactor to improve maintainability for Bodhi Server CLI Issues pertaining to Bodhi's server command line tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bodhi-manage-releases
2 participants