Execute skipped tests for Python 3 #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
bowlofeggs
suggested changes
Aug 15, 2018
bodhi/server/consumers/masher.py
Outdated
| @@ -1302,7 +1302,7 @@ def _wait_for_sync(self): | |||
| master_repomd_url = self._get_master_repomd_url(arch) | |||
|
|
|||
| with open(repomd) as repomdf: | |||
| checksum = hashlib.sha1(repomdf.read()).hexdigest() | |||
| checksum = hashlib.sha1(str(repomdf.read()).encode('utf-8')).hexdigest() | |||
There was a problem hiding this comment.
You should not need the call to str() here:
$ python3
>>> import hashlib
>>> with open('bodhi/server/__init__.py') as tf:
... hashlib.sha1(tf.read().encode('utf-8')).hexdigest()
...
'56ee127f54c7fcf7453817d257106747cfa9b461'
bodhi/server/consumers/masher.py
Outdated
| @@ -1311,7 +1311,7 @@ def _wait_for_sync(self): | |||
| self.log.exception('Error fetching repomd.xml') | |||
| time.sleep(200) | |||
| continue | |||
| newsum = hashlib.sha1(masterrepomd.read()).hexdigest() | |||
| newsum = hashlib.sha1(str(masterrepomd.read()).encode('utf-8')).hexdigest() | |||
Signed-off-by: Vismay Golwala <[email protected]>
bowlofeggs
approved these changes
Aug 21, 2018
|
This patch is planned to be included in the upcoming 3.10.0 release: #2556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vismay Golwala [email protected]