Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bodhi's update create form does not gracefully handle errors from the backend #3035

Closed
bowlofeggs opened this issue Feb 20, 2019 · 4 comments · Fixed by #3042
Closed

Bodhi's update create form does not gracefully handle errors from the backend #3035

bowlofeggs opened this issue Feb 20, 2019 · 4 comments · Fixed by #3042
Labels
JS Issues pertaining to Bodhi's JavaScript code WebUI Issues pertaining to Bodhi's web interface

Comments

@bowlofeggs
Copy link
Contributor

When users were hitting #3024, the web form's submit button would spin until it hit the error and then it would stop spinning, but no error was reported to the user. This made it non-obvious that there was a problem, and also made it more difficult to determine what the real problem was.

The web form (and all of Bodhi's forms) should be able to display errors from the backend to the user on non-2xx codes.
@bowlofeggs bowlofeggs added JS Issues pertaining to Bodhi's JavaScript code WebUI Issues pertaining to Bodhi's web interface labels Feb 20, 2019
@sebwoj
Copy link
Collaborator

sebwoj commented Feb 21, 2019

It looks like duplication of #2312

sebwoj added a commit to sebwoj/bodhi that referenced this issue Feb 26, 2019
@sebwoj
Add json response handler for server internal errors
c132519 
Fixes fedora-infra#3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
@sebwoj sebwoj mentioned this issue Feb 26, 2019
Merged
@bowlofeggs
Copy link
Contributor Author

@sebwoj ah yeah, I guess it is ultimately the same thing. The other one is a bit more specific though I guess. Thanks!

@bowlofeggs bowlofeggs mentioned this issue Mar 12, 2019
Closed
bowlofeggs pushed a commit to sebwoj/bodhi that referenced this issue Mar 13, 2019
@sebwoj @bowlofeggs
Add json response handler for server internal errors
a76fa77 
Fixes fedora-infra#3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
mergify bot pushed a commit that referenced this issue Mar 13, 2019
@sebwoj @mergify
Add json response handler for server internal errors
2d30986 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
@bowlofeggs bowlofeggs mentioned this issue Mar 22, 2019
Closed
3 tasks
mergify bot pushed a commit that referenced this issue Mar 26, 2019
@sebwoj
Add json response handler for server internal errors
78eb023 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)

# Conflicts:
#	bodhi/server/views/generic.py
abompard pushed a commit that referenced this issue Mar 26, 2019
@sebwoj @abompard
Add json response handler for server internal errors
79a7f9b 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
abompard pushed a commit that referenced this issue Mar 26, 2019
@sebwoj @abompard
Add json response handler for server internal errors
e515598 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
abompard pushed a commit that referenced this issue Mar 26, 2019
@sebwoj @abompard
Add json response handler for server internal errors
b8ebb8a 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
abompard pushed a commit that referenced this issue Mar 27, 2019
@sebwoj @abompard
Add json response handler for server internal errors
3831b09 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
abompard pushed a commit that referenced this issue Mar 27, 2019
@sebwoj @abompard
Add json response handler for server internal errors
63c07a2 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
abompard pushed a commit that referenced this issue Mar 27, 2019
@sebwoj @abompard
Add json response handler for server internal errors
94de0d5 
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <[email protected]>
(cherry picked from commit 2d30986)
@bowlofeggs
Copy link
Contributor Author

A fix for this issue is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor Author

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release
https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JS Issues pertaining to Bodhi's JavaScript code WebUI Issues pertaining to Bodhi's web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add json response handler for server internal errors sebwoj/bodhi
2 participants
@bowlofeggs @sebwoj