Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "masher" to "composer" #2151

Closed
bowlofeggs opened this issue Feb 14, 2018 · 3 comments · Fixed by #2944
Closed

Rename "masher" to "composer" #2151

bowlofeggs opened this issue Feb 14, 2018 · 3 comments · Fixed by #2944
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Composer Issues related to the composer Refactor Issues that are a refactor to improve maintainability for Bodhi

Comments

@bowlofeggs
Copy link
Contributor

With the next major version of Bodhi, we should rename the "masher" to "composer" since mash is no longer used.
@bowlofeggs bowlofeggs added Composer Issues related to the composer Refactor Issues that are a refactor to improve maintainability for Bodhi Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release labels Feb 14, 2018
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Feb 15, 2018
@bowlofeggs
Refactor the composer to split pungi code into a new base class.
7b4a029 
In order to prepare the way for Bodhi to support composing
containers we need to split pungi-specific code out of the
MasherThread base class so the general composition code can be
reused by the soon-to-be-written container composing class.

This commit does that refactoring work, and renames some uses of
"mash" to "compose". Not all uses are renamed here, as some of them
would not be backwards compatible (see fedora-infra#2151).

re fedora-infra#2028

Signed-off-by: Randy Barlow <[email protected]>
This was referenced Feb 15, 2018
Merged
Merged
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Feb 26, 2018
@bowlofeggs
Refactor the composer to split pungi code into a new base class.
8270859 
In order to prepare the way for Bodhi to support composing
containers we need to split pungi-specific code out of the
MasherThread base class so the general composition code can be
reused by the soon-to-be-written container composing class.

This commit does that refactoring work, and renames some uses of
"mash" to "compose". Not all uses are renamed here, as some of them
would not be backwards compatible (see fedora-infra#2151).

re fedora-infra#2028

Signed-off-by: Randy Barlow <[email protected]>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Feb 26, 2018
@bowlofeggs
Refactor the composer to split pungi code into a new base class.
d6fd247 
In order to prepare the way for Bodhi to support composing
containers we need to split pungi-specific code out of the
MasherThread base class so the general composition code can be
reused by the soon-to-be-written container composing class.

This commit does that refactoring work, and renames some uses of
"mash" to "compose". Not all uses are renamed here, as some of them
would not be backwards compatible (see fedora-infra#2151).

re fedora-infra#2028

Signed-off-by: Randy Barlow <[email protected]>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Mar 6, 2018
@bowlofeggs
Refactor the composer to split pungi code into a new base class.
f44c476 
In order to prepare the way for Bodhi to support composing
containers we need to split pungi-specific code out of the
MasherThread base class so the general composition code can be
reused by the soon-to-be-written container composing class.

This commit does that refactoring work, and renames some uses of
"mash" to "compose". Not all uses are renamed here, as some of them
would not be backwards compatible (see fedora-infra#2151).

re fedora-infra#2028

Signed-off-by: Randy Barlow <[email protected]>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jan 17, 2019
@sebwoj
Rename masher to composer
6d9215b 
Fixes fedora-infra#2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
@sebwoj sebwoj mentioned this issue Jan 17, 2019
Merged
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jan 17, 2019
@sebwoj
Rename masher to composer
cbc4d50 
Fixes fedora-infra#2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jan 17, 2019
@sebwoj
Rename masher to composer
834282f 
Fixes fedora-infra#2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Feb 12, 2019
@sebwoj
Rename masher to composer
83d1121 
Fixes fedora-infra#2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Feb 15, 2019
@sebwoj
Rename masher to composer
9cdec71 
Fixes fedora-infra#2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
mergify bot pushed a commit that referenced this issue Mar 7, 2019
@sebwoj @mergify
Rename masher to composer
27ea7fb 
Fixes #2151

Signed-off-by: Sebastian Wojciechowski <[email protected]>
@sebwoj
Copy link
Collaborator

sebwoj commented Mar 8, 2019

@bowlofeggs Since github has an issue closing "Bodhi issues", we should do it manualy ;/

@bowlofeggs
Copy link
Contributor Author

This change is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor Author

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release
https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Composer Issues related to the composer Refactor Issues that are a refactor to improve maintainability for Bodhi
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename masher to composer sebwoj/bodhi
2 participants
@bowlofeggs @sebwoj