Add Missing Translations

[tsmith123]

This PR fixes a missing translation on NoConnectedServices page and tweaks translation keys in en.json

OLD

NEW

Summary by CodeRabbit

• Documentation

  • Updated localization strings to improve clarity about Fedimint federation services and guardian roles
  • Refined text descriptions for services and guardians in the English language configuration

• Chores

  • Removed and updated translation keys to enhance user understanding

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 23, 2025 9:16pm

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/router/src/home/NoConnectedServices.tsx

Oops! Something went wrong! :(

ESLint: 8.40.0

Error: Cannot read config file: /apps/router/.eslintrc.js
Error: Cannot find module '@fedimint/eslint-config'
Require stack:

• /apps/router/.eslintrc.js
• /node_modules/@eslint/eslintrc/dist/eslintrc.cjs
• /node_modules/eslint/lib/cli-engine/cli-engine.js
• /node_modules/eslint/lib/eslint/eslint.js
• /node_modules/eslint/lib/eslint/index.js
• /node_modules/eslint/lib/cli.js
• /node_modules/eslint/bin/eslint.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Module._load (node:internal/modules/cjs/loader:1074:27)
  at TracingChannel.traceSync (node:diagnostics_channel:315:14)
  at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
  at Module.require (node:internal/modules/cjs/loader:1339:12)
  at require (node:internal/modules/helpers:135:16)
  at Object. (/apps/router/.eslintrc.js:1:18)
  at Module._compile (node:internal/modules/cjs/loader:1546:14)
  at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
  at Module.load (node:internal/modules/cjs/loader:1317:32)

📝 Walkthrough

Walkthrough

This pull request focuses on updating localization content in the Fedimint router application. The changes modify the English translation JSON file and the corresponding React component to provide clearer descriptions about services and guardians in a Fedimint federation. The modifications involve removing the "services-title" key, updating the "services-description", and adding new keys for explaining guardians' roles.

Changes

File	Change Summary
apps/router/src/home/NoConnectedServices.tsx	Updated translation key references to display new localization text
apps/router/src/languages/en.json	Removed services-title, updated services-description, added guardians and guardians-description keys

Possibly related PRs

• fix: add missing en keys and run translate #526: Localization updates for services and guardians, directly connected to the current changes in translation keys

Suggested reviewers

• bradleystachurski

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8f5e6f and 34fffce.

📒 Files selected for processing (2)

• apps/router/src/home/NoConnectedServices.tsx (1 hunks)
• apps/router/src/languages/en.json (1 hunks)

🔇 Additional comments (3)

apps/router/src/languages/en.json (1)

40-42: LGTM!

The translation keys and their content are well-structured and provide clear, informative descriptions of services and guardians in the Fedimint federation.

apps/router/src/home/NoConnectedServices.tsx (2)

21-21: Verify translation key exists

Ensure the 'router.services-description' translation key is properly defined in the localization files.

✅ Verification successful

Translation key verified successfully

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for the translation key in all JSON files
rg -g "*.json" "services-description"

Length of output: 2624

---

24-25: Verify guardian translation keys exist

Ensure both 'router.guardians' and 'router.guardians-description' translation keys are defined in the localization files.

✅ Verification successful

Translation keys verified successfully

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for both guardian-related translation keys
rg -g "*.json" "guardians.*"

Length of output: 11751

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kleysc]

Nice catch!
Great job! LGTM 🚀

[alexlwn123]

LGTM