rdkafka-sys: upgrade to librdkafka v1.4.2 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
force-pushed
the
rdkafka-1.4.2
branch
6 times, most recently
from
de3c86e to
7f77b2a
Compare
fede1024
approved these changes
May 5, 2020
Great point, thanks! Looks like that test is not getting run in CI. Addressing that now. |
benesch
force-pushed
the
rdkafka-1.4.2
branch
2 times, most recently
from
1bf9a2b to
a49d655
Compare
Also allow rdkafka and rdkafka-sys to be versioned independently by making rdkafka-sys follow SemVer. This will fix future scenarios like the one described in issue fede1024#211.
We weren't catching failures in test_version_check previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #234, which is unmergeable due to an upstream breakage of the Windows build. That should be fixed in v1.4.2. Still awaiting the official release, but kicking things off with rc2 here.
Also allow rdkafka and rdkafka-sys to be versioned independently by
making rdkafka-sys follow SemVer. This will fix future scenarios like
the one described in issue #211.