Improve build system + prepare for 0.22 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdkafka had been upgraded to the 2018 edition of Rust, but not rdkafka-sys.
Previously we were using `cargo:rustc-link-lib` dependencies to link some of our *-sys dependencies, but not others. Using `extern crate` is cleaner. Also, ensure sasl2 is linked for both the CMake and non-CMake builds. Since there's no *-sys crate for sasl2, we just output the link directive directly and hope that the library exists.
Rather than maxing out the host's cores, let Cargo tell Make how much parallelism is available.
To avoid breaking backwards compatibility, libz becomes a default feature.
benesch
force-pushed
the
build-solidify
branch
4 times, most recently
from
00f4ef9 to
b13b8aa
Compare
fede1024
approved these changes
Dec 1, 2019
README.md
Outdated
| version = "~0.21" | ||
| features = ["ssl", "sasl"] | ||
| [dependencies] | ||
| rdkafka = { version = "0.22", features = ["cmake-build", "dynamic-linking"] } |
There was a problem hiding this comment.
Is cmake-build necessary when using dynamic linking?
There was a problem hiding this comment.
D'oh, good catch, thanks!
benesch
force-pushed
the
build-solidify
branch
from
b13b8aa to
328d9a0
Compare
We can't always get CMake, mklove, and Cargo to agree on what version of each library to use, but we can try.
benesch
force-pushed
the
build-solidify
branch
from
328d9a0 to
7e27588
Compare
|
Thank you for building the library in the first place! Happy to keep things moving forward. |
|
Should I build a new release? Or are there still open issues that we want to solve first? |
|
Yes, please! Folks seem to be ready for a new release, and there’s nothing else that seems urgent. (I want to get to the futures stuff ASAP, but better to put that in 0.23 instead of the next release, since there’s a lot of stuff in the ecosystem that’s still on tokio 0.1, and those folks could benefit from the past six months of compatible improvements here.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably easiest just to look at the commit messages and the updates to the changelog/README.