Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should OwnedHeaders be Sync? #200

Closed
sd2k opened this issue Dec 23, 2019 · 1 comment · Fixed by #203
Closed

Should OwnedHeaders be Sync? #200

sd2k opened this issue Dec 23, 2019 · 1 comment · Fixed by #203

Comments

@sd2k
Copy link
Contributor

sd2k commented Dec 23, 2019

Similar to #189 - could OwnedHeaders be Sync as well as Send?

The lack of Sync on OwnedHeaders means that an OwnedMessage is also !Sync, so it can't be easily used with async/await for the same reasons identified in #189 for BorrowedMessage.
benesch added a commit to benesch/rust-rdkafka that referenced this issue Dec 31, 2019
@benesch
Implement Sync on OwnedHeaders
17db9c0 
The rationale here is the same as the rationale for implementing Sync on
BorrowedMessage (2779f77).

Fix fede1024#200.
@benesch benesch mentioned this issue Dec 31, 2019
Merged
benesch added a commit to benesch/rust-rdkafka that referenced this issue Dec 31, 2019
@benesch
Implement Sync on OwnedHeaders
f071934 
The rationale here is the same as the rationale for implementing Sync on
BorrowedMessage (2779f77).

Fix fede1024#200.
@benesch
Copy link
Collaborator

benesch commented Dec 31, 2019

Yep, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Sync on OwnedHeaders benesch/rust-rdkafka
2 participants
@benesch @sd2k