Skip to content

Commit

Permalink
PERF: don't draw barplots by dflt (close biocore#343)
Browse files Browse the repository at this point in the history
  • Loading branch information
fedarko committed Aug 20, 2020
1 parent f89b2bb commit 6aca69b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ Similarly to other tree visualization tools like [iTOL](https://itol.embl.de/),

Barplots in Empress are compatible with either the rectangular or circular layouts. Here we'll use the rectangular layout, but feel free to follow along with the circular layout if you prefer!

First off, change the layout to *Rectangular* (using the *Layout* section of the main menu), and then open up the *Barplots* section of the main menu and check the `Draw Barplots?` checkbox. By default, a red bar of uniform length will be drawn for every tip in the tree:
First off, change the layout to *Rectangular* (using the *Layout* section of the main menu), and then open up the *Barplots* section of the main menu and check the `Draw Barplots?` checkbox. Click the *Update* button that appears. By default, a red bar of uniform length will be drawn for every tip in the tree:

![empress barplots initial view](docs/moving-pictures/img/empress_barplots_1.png)

Expand Down
4 changes: 3 additions & 1 deletion empress/support_files/js/barplot-panel-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ define(["underscore", "BarplotLayer", "Colorer"], function (
scope.addOptions.classList.remove("hidden");
scope.updateButton.classList.remove("hidden");
scope.enabled = true;
scope.empress.drawBarplots(scope.layers);
// We don't immediately draw barplots: see
// https://github.com/biocore/empress/issues/343. The user has
// to click "Update" first.
} else {
scope.layerContainer.classList.add("hidden");
scope.addOptions.classList.add("hidden");
Expand Down

0 comments on commit 6aca69b

Please sign in to comment.