Add AMQP Adapter #12
Add AMQP Adapter #12
Conversation
|
Problem with params uri (not enough test) sorry |
|
Oh hell yeah! Stoked to check this out! |
|
This is great! Do you have an idea how we could test this on Travis? |
|
To be honest ! I have no idea ... |
|
I think I do. I've done a bunch with RabbitMQ. |
| msg.ev = ev; | ||
| msg.data = data; | ||
| //amqp name | ||
| if(ch){ |
There was a problem hiding this comment.
I'd like to see these variables longer. I know that ch means channel but people new to RabbitMQ may not.
|
@tinque this is solid! Thanks! I made a couple minor comments but I am also fine making those changes and looking into getting tests running on travis. This is good to 🚢 ! 🎉 🍻 |
| ch.consume(q.queue, function(msg) { | ||
| var temp = JSON.parse(msg.content.toString()); | ||
| onmessage(temp.ev,temp.data); | ||
| }, {noAck: true}); |
There was a problem hiding this comment.
We may later on, want to turn on "acks" but for now this is totally fine.
|
I'll figure out what's going on with the tests. I'll probably add some more and fix them up over the next couple days. |
I added a AMQP Adpater. (tested with RabbitMQ)