Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse relation expressions at service creation time #69

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Parse relation expressions at service creation time #69

merged 2 commits into from
Nov 1, 2019

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Oct 16, 2019

Parse relation expressions options (allowedEager, allowedInsert and allowedUpsert) in constructor instead of passing strings for parsing every service call.

Also in types indicate that those options can be not only strings but objects too (an objection notation of a relation or a result of RelationExpression.create).

@vonagam
Copy link
Contributor Author

vonagam commented Oct 17, 2019

Added mergeAllowUpsert and mergeAllowInsert params, work the same as mergeAllowEager for allowedEager and have the same use cases: when you want to limit relations on which a user can operate based on some criteria.

@dekelev
Copy link
Member

dekelev commented Nov 1, 2019

Thanks, looks good!

@dekelev dekelev merged commit 23c92b8 into feathersjs-ecosystem:master Nov 1, 2019
@dekelev
Copy link
Member

dekelev commented Nov 1, 2019

Released in v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants