updating to new feathers errors. Closes #3.

feathersjs-ecosystem · Jun 13, 2014 · 110e7ee · 110e7ee
1 parent f2b35fb
commit 110e7ee
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 35 deletions.
diff --git a/lib/errors.js b/lib/errors.js
diff --git a/lib/mongodb.js b/lib/mongodb.js
@@ -1,5 +1,6 @@
 var Proto = require('uberproto');
 var mongo = require('mongoskin');
+var errors = require('feathers').errors.types;
 var _ = require('lodash');
 
 // TODO (EK): Does order matter for how these filters
@@ -120,7 +121,7 @@ var MongoService = Proto.extend({
 
     if (_.isFunction(id)){
       cb = id;
-      return cb(new Error('An string or number id must be provided'));
+      return cb(new errors.BadRequest('An string or number id must be provided'));
     }
 
     if (_.isFunction(params)){
@@ -135,7 +136,7 @@ var MongoService = Proto.extend({
     }
 
     if (!this.collection) {
-      return cb(new Error('No collection specified'));
+      return cb(new errors.GeneralError('No collection specified'));
     }
 
     this.store.collection(this.collection).findById(id, params.query, cb);
@@ -149,7 +150,7 @@ var MongoService = Proto.extend({
     }
 
     if (!this.collection) {
-      return cb(new Error('No collection specified'));
+      return cb(new errors.GeneralError('No collection specified'));
     }
 
     this.store.collection(this.collection).insert(data, params, function(error, data) {
@@ -169,7 +170,7 @@ var MongoService = Proto.extend({
     }
 
     if (!this.collection) {
-      return cb(new Error('No collection specified'));
+      return cb(new errors.GeneralError('No collection specified'));
     }
 
     this.store.collection(this.collection).updateById(id, data, params, function(error) {
@@ -189,7 +190,7 @@ var MongoService = Proto.extend({
     }
 
     if (!this.collection) {
-      return cb(new Error('No collection specified'));
+      return cb(new errors.GeneralError('No collection specified'));
     }
 
     this.store.collection(this.collection).removeById(id, params.query, cb);

diff --git a/package.json b/package.json
@@ -34,7 +34,11 @@
     "mongoskin": "^0.6.1",
     "uberproto": "~1.1.0"
   },
+  "peerDependencies": {
+    "feathers": ">=1.0.x"
+  },
   "devDependencies": {
+    "feathers": ">=1.0.x",
     "chai": "^1.7.2",
     "database-cleaner": "~0.7.0",
     "grunt": "^0.4.5",