Fix tests to work with latest Sinon (#674)

feathersjs-ecosystem · May 31, 2018 · 1c5f6eb · 1c5f6eb
1 parent 9ce13c9
commit 1c5f6eb
Show file tree

Hide file tree

Showing 9 changed files with 1,325 additions and 1,395 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/express/authenticate.test.js b/test/express/authenticate.test.js
@@ -32,8 +32,8 @@ describe('express:authenticate', () => {
   });
 
   afterEach(() => {
-    next.reset();
-    res.status.reset();
+    next.resetHistory();
+    res.status.resetHistory();
   });
 
   describe('when strategy name is missing', () => {

diff --git a/test/express/emit-events.test.js b/test/express/emit-events.test.js
@@ -28,7 +28,7 @@ describe('express:emitEvents', () => {
   });
 
   afterEach(() => {
-    req.app.emit.reset();
+    req.app.emit.resetHistory();
   });
 
   it('calls next', next => {

diff --git a/test/express/failure-redirect.test.js b/test/express/failure-redirect.test.js
@@ -30,9 +30,9 @@ describe('express:failureRedirect', () => {
   });
 
   afterEach(() => {
-    res.clearCookie.reset();
-    res.redirect.reset();
-    res.status.reset();
+    res.clearCookie.resetHistory();
+    res.redirect.resetHistory();
+    res.status.resetHistory();
   });
 
   describe('when redirect is set on the hook', () => {

diff --git a/test/express/set-cookie.test.js b/test/express/set-cookie.test.js
@@ -34,8 +34,8 @@ describe('express:setCookie', () => {
   });
 
   afterEach(() => {
-    res.cookie.reset();
-    res.clearCookie.reset();
+    res.cookie.resetHistory();
+    res.clearCookie.resetHistory();
   });
 
   describe('when cookies are not enabled', () => {

diff --git a/test/express/success-redirect.test.js b/test/express/success-redirect.test.js
@@ -27,8 +27,8 @@ describe('express:successRedirect', () => {
   });
 
   afterEach(() => {
-    res.redirect.reset();
-    res.status.reset();
+    res.redirect.resetHistory();
+    res.status.resetHistory();
   });
 
   describe('when redirect is set on the hook', () => {

diff --git a/test/hooks/authenticate.test.js b/test/hooks/authenticate.test.js
@@ -38,7 +38,7 @@ describe('hooks:authenticate', () => {
   });
 
   afterEach(() => {
-    authenticator.reset();
+    authenticator.resetHistory();
   });
 
   describe('when strategy name is missing', () => {

diff --git a/test/integration/primus.test.js b/test/integration/primus.test.js
@@ -65,7 +65,7 @@ describe('Primus authentication', function () {
   });
 
   afterEach(() => {
-    hook.reset();
+    hook.resetHistory();
   });
 
   after(() => {

diff --git a/test/integration/socketio.test.js b/test/integration/socketio.test.js
@@ -59,7 +59,7 @@ describe('Socket.io authentication', function () {
   });
 
   afterEach(() => {
-    hook.reset();
+    hook.resetHistory();
   });
 
   after(() => {