Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Override the udf name when provided as input to an on demand transformation #5094

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

blaketastic2
Copy link
Contributor

What this PR does / why we need it:

This PR allows the user to define an ODFV function with a name override so we don't have to use the function name if we don't want to. This is also meant to provide feature parody with other ways of defining an ODFV.

Which issue(s) this PR fixes:

N/A

Misc

N/A

@blaketastic2 blaketastic2 requested a review from a team as a code owner February 25, 2025 17:29
@blaketastic2 blaketastic2 changed the title Override the udf name when provided feat: override the udf name when provided Feb 25, 2025
Signed-off-by: Blake <[email protected]>
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks Blake!!!

@franciscojavierarceo franciscojavierarceo changed the title feat: override the udf name when provided feat: Override the udf name when provided as input to an on demand transformation Feb 25, 2025
@blaketastic2
Copy link
Contributor Author

@franciscojavierarceo this failure seems like a flaky test

@franciscojavierarceo franciscojavierarceo merged commit 8a714bb into feast-dev:master Feb 25, 2025
28 of 33 checks passed
@franciscojavierarceo
Copy link
Member

yeah it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants