Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Operator - make onlineStore the default service #5044

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Feb 11, 2025

What this PR does / why we need it:

Currently, the default deployed feast server container is the remote registry grpc server. With this change, the default will change to an online feature server container. The user can still run an offline and/or registry server container if they like.

The reasoning behind this change is as follows:

  • The online feature server is the more commonly used / necessary component of a FeatureStore.
  • The online feature server is a read-only service, so is more secure out of the box than a remote registry service. As such, running the grpc registry should be an explicit choice by the user.
  • The remote registry provider type and server is a still relatively new feature and more of an edge use-case

@tchughesiv tchughesiv force-pushed the onlineDefault branch 5 times, most recently from 4a35aa5 to a0f9d75 Compare February 12, 2025 17:14
@tchughesiv tchughesiv marked this pull request as ready for review February 12, 2025 21:39
@tchughesiv tchughesiv requested a review from a team as a code owner February 12, 2025 21:39
Copy link
Contributor

@redhatHameed redhatHameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchughesiv tchughesiv merged commit 6c92447 into feast-dev:master Feb 13, 2025
28 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Feb 17, 2025
# [0.46.0](v0.45.0...v0.46.0) (2025-02-17)

### Bug Fixes

* Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed))
* Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35))
* Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a))
* Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b))
* Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447))
* Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548))
* Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4))
* Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa))
* Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca))

### Features

* Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21))
* Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d))
* Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7))
* Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7))
* Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants