-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Feast Operator example with Postgres in TLS mode. #5028
feat: Feast Operator example with Postgres in TLS mode. #5028
Conversation
… up the feast using operator. Signed-off-by: lrangine <[email protected]>
…stgres tls as well. Signed-off-by: lrangine <[email protected]>
e89ee80
to
4b75e78
Compare
Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
@tchughesiv @lokeshrangineni can use same directory |
This example is having multiple notebooks isolates the group of steps. It appears to be the same notebooks as any further preferences? |
if it's not fitting with existing example, then sure you can go with existing approach. The idea is to create a note for an example like |
imo, the cleanest way would be to piggy-back off of the existing quickstart. Just add another |
…orporating code review comments. Signed-off-by: lrangine <[email protected]>
@lokeshrangineni that said, if its a huge ordeal to combine them... i'm completely fine keeping them separate as well After removing the demo notebook there is not lot of synergy between |
… Also fixed some broken links. Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>
examples/operator-postgres-tls-demo/01-Install-postgres-tls-using-helm.ipynb
Show resolved
Hide resolved
1. Now the numbers are automatically ordered when we render to avoid renumbering when we add an example in between. 2. Added separate section for the feast go operator examples. Signed-off-by: lrangine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokeshrangineni to ensure this demo continues to work, you may want to specify a version of the bitnami/postgresql
helm chart during install. future changes/release could derail this example.
Signed-off-by: lrangine <[email protected]>
I have incorporated in the commit |
@lokeshrangineni WDYT Squashing commits to single ? |
@redhatHameed @lokeshrangineni no need to squash them... the merge will |
already incorporated or responded to the request.
This reverts commit 2c46f6a.
Feast Operator example with Postgres in TLS mode.