feat: Add Milvus as Online Store #4843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
franciscojavierarceo
commented
Dec 12, 2024
franciscojavierarceo
commented
- feat: Make entity value_type mandatory with deprecation warning
- style: Fix import sorting in entity files
- chore: Skip tests for community/docs/examples paths
- feat: Add Milvus online store implementation\n\n- Implements MilvusOnlineStore with vector similarity search\n- Adds integration and unit tests\n- Follows existing vector store patterns\n- Supports L2, IP, and cosine similarity metrics
- Add deprecation warning when value_type is not specified for an entity - Add test cases to verify deprecation warning behavior - Prepare for making value_type mandatory in next release Issue: feast-dev#4670 Co-Authored-By: Francisco Javier Arceo <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- Reorder imports according to PEP8 - Group standard library imports together - Fix ruff linting issues Co-Authored-By: Francisco Javier Arceo <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…atory-entity-value-type feat: Make entity value_type mandatory with deprecation warning
Co-Authored-By: Francisco Javier Arceo <[email protected]>
…p-tests-docs-examples chore: Skip tests for community/docs/examples paths
…lineStore with vector similarity search\n- Adds integration and unit tests\n- Follows existing vector store patterns\n- Supports L2, IP, and cosine similarity metrics Co-Authored-By: Francisco Javier Arceo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.