Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing the tls_verify_client flag from feast cli for offline server. #4842

Merged

Conversation

lokeshrangineni
Copy link
Contributor

@lokeshrangineni lokeshrangineni commented Dec 11, 2024

Removing the tls_verify_client flag from feast cli for offline server. This flag is not useful and not needed anymore.

Fixes the Issue- 4846

@lokeshrangineni lokeshrangineni changed the title Feat: Adding ca file support for the offline server feat: Adding ca file support for the offline server Dec 11, 2024
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-tls-ca-support branch from 4d09d46 to 2568c38 Compare December 12, 2024 20:06
@lokeshrangineni lokeshrangineni changed the title feat: Adding ca file support for the offline server feat: Removing the tls_verify_client flag from feast cli for offline server. Dec 12, 2024
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-tls-ca-support branch from 4057373 to c1257c0 Compare December 12, 2024 20:36
@lokeshrangineni lokeshrangineni marked this pull request as ready for review December 12, 2024 20:53
@lokeshrangineni lokeshrangineni requested a review from a team as a code owner December 12, 2024 20:53
@lokeshrangineni lokeshrangineni self-assigned this Dec 12, 2024
@tchughesiv tchughesiv enabled auto-merge (squash) December 16, 2024 19:45
Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchughesiv tchughesiv merged commit 8320e23 into feast-dev:master Dec 16, 2024
21 checks passed
tchughesiv pushed a commit to tchughesiv/feast that referenced this pull request Dec 17, 2024
…server. (feast-dev#4842)

* Removing the tls_verify_client flag for offline server from feast application code.

Signed-off-by: lrangine <[email protected]>

* fixing lint errors. formatted the code.

Signed-off-by: lrangine <[email protected]>

---------

Signed-off-by: lrangine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants